Document the provided metadata, and related migration to perform #274
+1,588
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2022
Signed-off-by: Ben Fuller <[email protected]> Co-authored-by: Ben Fuller <[email protected]>
This resource can inadvertently miss Pull Requests due to out-of-order commits across PRs. If PR#2 is opened after PR#1, but the head commit of PR#2 is older than the head commit of PR#1, the resource will not include PR#2 in the list of new versions provided to Concourse. Rather than attempt to find a different way of tracking which PRs are "new" given an input version, we can remove the date-based filtering and return all open PRs. Concourse can deduplicate versions based on metadata, which means that we will only trigger new jobs for versions that Concourse hasn't seen before. This makes it easier for teams to use this resource to track PRs in Concourse, since they no longer have to ensure that a PR has a later head commit than all currently-opened PRs in order to notify Concourse that their PR exists.
This triggers CI when the approved review count changes, which is not the correct behaviour Co-authored-by: Kieron Browne <[email protected]>
This allows finer control of the RequiredReviewApprovals property. It is ignored if the user is in one of the trusted teams, or in the trusted user list. This way we can run CI on trusted users without needing an approval, but untrusted users will require a PR approval before their changes are run in CI. In order to reduce the number of calls to github we are caching trusted users for the duration of a single check. Note: github should be configured to remove approvals if new commits are received on a PR so that a user doesn't circumvent security by pushing a malicious commit after an approved legitimate commit on the same PR. Co-authored-by: Kieron Browne <[email protected]> Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
Add details on `trusted_teams` and `trusted_users` source configuration parameters. Co-authored-by: Danail Branekov <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>
`trusted_teams`/`trusted_users` + various fixes
bgandon
force-pushed
the
document-metadata
branch
from
22d8c82 to
a01bb28
Compare
|
Closing in favor of cloudfoundry-community#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Telia folks,
In this PR, I've documented the metadata that is provided, and how to migrate from
jtarchie/github-pullrequestwhen it comes to handling metadata.Best